Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the errors should have a better spelling #53

Open
weissi opened this issue Mar 6, 2019 · 2 comments
Open

the errors should have a better spelling #53

weissi opened this issue Mar 6, 2019 · 2 comments
Labels
kind/enhancement Improvements to existing feature.
Milestone

Comments

@weissi
Copy link
Member

weissi commented Mar 6, 2019

Currently, the error look like this:

NIOHTTP2Errors.NoSuchStream(...)

but I think it should be either

NIOHTTP2Error.noSuchStream(...) // imitating an open enum on top of a struct

or

NIOHTTP2Errors.NoSuchStreamError(...)

IMHO, preferably the former

@weissi weissi added this to the 1.0.0 milestone Mar 6, 2019
@weissi weissi modified the milestones: 1.0.0, 2.0.0 Mar 26, 2019
@weissi weissi added the kind/enhancement Improvements to existing feature. label Mar 26, 2019
@natikgadzhi
Copy link

If we do that, though, we should deprecate the existing ones, and leave them there for another release, right?

@Lukasa
Copy link
Contributor

Lukasa commented Aug 29, 2023

Yeah, but this is non-urgent enough that I’d be inclined to leave these until we did a new major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants