[5.3] On ELF platforms, remove the host toolchain rpath from executables and shared libraries #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finagolfin
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
rballard
as code owners
|
@swift-ci please test |
neonichu
approved these changes
Aug 31, 2020
|
Pulling this back sounds good to me, but ultimately @rballard's call. |
|
I think that this is pretty important - it should remove hardcoded paths from the build host which are a problem, we should try to get this into the 5.3 release even though we are cutting it really close. |
compnerd
approved these changes
Aug 31, 2020
abertelrud
approved these changes
Aug 31, 2020
|
this looks like a good improvement, we will put into an update as soon as possible |
rballard
reviewed
Sep 1, 2020
|
Sounds good. |
|
Looks like this will need an update because of conflicts in the bootstrap script that we introduced. Sorry about that! |
…d shared libraries before installing.
|
No problem, an easy fix. |
|
@swift-ci please test |
|
We've shipped 5.3 and are about to start taking fixes for the next patch release. Let's hold this one until Monday, but I expect to approve then. |
rballard
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before installing.
It has been suggested to me by some Swift devs that this would be good to get in before the 5.3 release, a cherry-pick from #2703.
This should be completely safe for the 5.3 branch, as it's just removing the build toolchain's stdlib rpath, which should be unused by SPM.