Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement (Sugared) Bound Generic Extensions #41172

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Feb 3, 2022

A scoped-down version of #39307. Implement extension of bound generic types. The important bit here is in TypeCheckGeneric where we now use the underlying type of a typealias and its associated nominal type decl when we're generating substitutions for the extended type.

Put this behind a new experimental flag

-enable-experimental-bound-generic-extensions

Resolves SR-4875
Resolves rdar://84960366

@CodaFi CodaFi requested a review from Azoy February 3, 2022 00:45
A scoped-down version of swiftlang#39307. Implement extension of bound generic types. The important bit here is in TypeCheckGeneric where we now use the underlying type of a typealias and its associated nominal type decl when we're generating substitutions for the extended type.

Put this behind a new experimental flag

-enable-experimental-bound-generic-extensions

Resolves SR-4875
Resolves rdar://17434633
@CodaFi
Copy link
Contributor Author

CodaFi commented Feb 3, 2022

@swift-ci smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Feb 3, 2022

@swift-ci smoke test macOS platform

@CodaFi CodaFi merged commit f5b4092 into swiftlang:main Feb 3, 2022
@CodaFi CodaFi deleted the special-sauce branch February 3, 2022 17:19
@Azoy
Copy link
Contributor

Azoy commented Feb 3, 2022

Love it! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants