-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android][test] Disable new SwiftToCxxToSwift Interop test #62052
Conversation
@swift-ci please test and merge |
Looks like Mac CI broke in the morning, unrelated to this pull, CI will need to be run again. |
@swift-ci please smoke test macOS |
Looks like the Mac CI was broken again yesterday evening, will need to be run again. |
What's the |
@swift-ci please smoke test macOS |
@hyp, this one, several of the C++ Interop tests are currently disabled for Android with that same error:
|
I see, that's just bad SDK then :D |
Yeah, there's some issue with how the Bionic libc module map we use interacts with the Android libc++ modulemap and Swift now, which can be seen in #60272 also, that I'll need to look into at some point. Strangely, I didn't find any way to get clang to list what symbols are actually included in different modules, other than dumping the pcm files manually. @hyp, is there any better way that you use for such module debugging? I tried |
Not particularly. You would just need to figure out what module the |
No, it can't be an SDK issue, this isn't some fly-by-night SDK here: we're talking about the most widely used libc in the world in Bionic. I just looked and Obviously there are other differences between the two libcs too, for example, Swift provides its own libstdc++ module map that's used on linux, while the Android CI uses the libc++ module map that the Android NDK provides. @hyp, if you have any input on how I might track this down, I'd let to get this fixed before the 5.8 branch, particularly so that I can start including the Swift portions of the Swift compiler itself again, as I had to disable them with #60272. |
Whoo, Android CI is green again, for the first time in months! I don't expect it to stay this way for long, with the constant C++ Interop test regressions- I see 14 that are now disabled, including this one, and another 10 or so that fail natively- and diminished hardware resources on the CI, but at least we got it passing again. |
@drodriguez, this should get the Android CI green again, we've already disabled several Interop tests that show this
mbstate_t
error.