Preliminary Sema support for generic subscripts #7683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
sema-generic-subscripts
branch
from
6f6ae93 to
b9d8619
Compare
|
@swift-ci Please test |
|
Build failed |
Get ready to handle lookup of generic parameters into a DeclContext that is a SubscriptDecl. No functional change yet, this this code path is not reachable.
Subscripts in generic context will soon have a GenericFunctionType, so get ready to handle that.
Subscripts in generic context will soon have a GenericFunctionType, so get ready to handle that.
Subscripts in generic context will soon have a GenericFunctionType, so get ready to handle that.
Subscripts in generic context will soon have a GenericFunctionType, so get ready to handle that.
Subscripts in generic context will soon have a GenericFunctionType, so get ready to handle that.
Fixes <rdar://problem/22086900>.
slavapestov
force-pushed
the
sema-generic-subscripts
branch
from
b9d8619 to
7133d92
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon the following previous PRs:
You still can't define a generic subscript yet; parser support is still pending. The main changes here that subscript declarations are now checked using the same logic as generic functions, which means their interface type becomes a GenericFunctionType when they are in generic context.
There was some fallout in CSRanking, mangling and SILGen that this fixes; once I start testing subscripts that have their own generic parameter lists, additional fixes will likely be necessary.
Amusingly, this fixes an 18-month SourceKit radar, rdar://22086900.