- B fix inline approvals with special unicode characters

fixes #216

Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Joss Hufnagel <43077216+blade290@users.noreply.github.com>
Co-Authored-By: Glen Warren <45516388+GRWrobotics@users.noreply.github.com>
Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com>

Author: 5 people

approvaltests/namer/inline_python_reporter.py

@@ -60,9 +60,9 @@ def get_test_source_file(self) -> str:
         return test_stack_frame.filename
 
     def create_received_file(self, received_path: str, test_source_file: str) -> str:
-        code = Path(test_source_file).read_text()
+        code = Path(test_source_file).read_text(encoding="utf-8")
 
-        original_received_text = Path(received_path).read_text()[:-1]
+        original_received_text = Path(received_path).read_text(encoding="utf-8")[:-1]
         received_text = original_received_text + self.footer
         # Handle preceding whitespace consistently across all lines.
         received_text = handle_preceeding_whitespace(received_text)
@@ -78,7 +78,7 @@ def create_received_file(self, received_path: str, test_source_file: str) -> str
             received_text, code, method_name, after_docstring_comment=trailing_comment
         )
         file = tempfile.NamedTemporaryFile(suffix=".received.txt", delete=False).name
-        Path(file).write_text(new_code)
+        Path(file).write_text(new_code, encoding="utf-8")
         return file
 
     def swap(

tests/approved_files/test_inline_approvals.test_unicode_and_special_characters__not_inline.approved.txt

@@ -0,0 +1 @@
+é

tests/test_inline_approvals.py

@@ -263,12 +263,25 @@ def test_escape_backslashes_mixed_sequences() -> None:
     assert escape_backslashes(text) == "a\\b\\c\\n".replace("\\", "\\\\")
 
 
-def test_unicode_and_special_characters_combining_acute() -> None:
+def test_unicode_and_special_characters__mismatch() -> None:
+    # TODO: consider inspecting the exception
     """
-    e\u0301
+    é
     """
+    text = "xe\u0301"  # 'e' + COMBINING ACUTE (2 code points)
+    with pytest.raises(ApprovalException):
+        verify(text, options=Options().with_reporter(ReportQuietly()).inline())
+
+
+def test_unicode_and_special_characters__missing() -> None:
     text = "e\u0301"  # 'e' + COMBINING ACUTE (2 code points)
-    verify(text, options=Options().inline())
+    with pytest.raises(ApprovalException):
+        verify(text, options=Options().with_reporter(ReportQuietly()).inline())
+
+
+def test_unicode_and_special_characters__not_inline() -> None:
+    text = "e\u0301"  # 'e' + COMBINING ACUTE (2 code points)
+    verify(text)
 
 
 def test_unicode_null_character() -> None: