We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Koa requestHook is set up to record request params as magic attributes, but it differs from the Express one in that we don't check which middleware is triggering the request hook: https://github.com/appsignal/appsignal-nodejs/blob/opentelemetry/src/client.ts#L216-L228
We need to record the parameters in the span just when in the router middleware, setting them in all the middleware spans is not needed.
The text was updated successfully, but these errors were encountered:
Relevant issue for filtering those parameters when collected: https://github.com/appsignal/opentelemetry/issues/48
Sorry, something went wrong.
Blocked while we wait on the OpenTelemetry release. open-telemetry/opentelemetry-js-contrib#1214
unflxw
No branches or pull requests
The Koa requestHook is set up to record request params as magic attributes, but it differs from the Express one in that we don't check which middleware is triggering the request hook: https://github.com/appsignal/appsignal-nodejs/blob/opentelemetry/src/client.ts#L216-L228
We need to record the parameters in the span just when in the router middleware, setting them in all the middleware spans is not needed.
The text was updated successfully, but these errors were encountered: