Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Function settings of a JS Object are not obeyed when copied/moved to another page #31475

Open
1 task done
shadabbuchh opened this issue Mar 5, 2024 · 2 comments
Open
1 task done

[Bug]: Function settings of a JS Object are not obeyed when copied/moved to another page #31475

shadabbuchh opened this issue Mar 5, 2024 · 2 comments
Assignees
@hetunandu @rohan-arthur
Labels
Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith JS Objects Issues related to JS Objects Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Query & JS Pod Issues related to the query & JS Pod

Comments

@shadabbuchh
Copy link
Contributor

shadabbuchh commented Mar 5, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

When we copy/move a JS Object to another page, the function settings are not obeyed in the new page. This leads to a lot of confusion & frustration as to why Run on page load or Confirm before calling are not getting triggered even if they are enabled.

Steps To Reproduce

  1. Create a JS Object.
  2. Write a code returning a value.
  3. Enable both Run on page load & Confirm before calling.
  4. Create a new page & copy the JS Object to the new page.
  5. Now reload the new page.

Expected: Since both Run on page load & Confirm before calling were enabled, we should see a confirmation modal asking for permission to run the function.
Actual: We do not see any such confirmation modal.

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

https://www.loom.com/share/903bc1a01550433d871ff1b51199f37c

Version

Cloud
@shadabbuchh shadabbuchh added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Production Needs Triaging Needs attention from maintainers to triage JS Objects Issues related to JS Objects labels Mar 5, 2024
@github-actions github-actions bot added the Javascript Product Issues related to users writing javascript in appsmith label Mar 5, 2024
@coderabbitai coderabbitai bot mentioned this issue Apr 10, 2024
Merged
@rishabhrathod01
Copy link
Contributor

Same is the case when a page is exported and later imported.

@Nikhil-Nandagopal Nikhil-Nandagopal added Medium Issues that frustrate users due to poor UX and removed High This issue blocks a user from building or impacts a lot of users labels Apr 25, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Query & JS Pod Issues related to the query & JS Pod label Aug 5, 2024
@shadabbuchh shadabbuchh assigned rohan-arthur and unassigned riteshkew Oct 1, 2024
@shadabbuchh
Copy link
Contributor Author

Also happens when we copy the JS Object in the same page.

@shadabbuchh shadabbuchh mentioned this issue Dec 31, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

@rohan-arthur rohan-arthur

Labels
Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith JS Objects Issues related to JS Objects Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Nikhil-Nandagopal @hetunandu @riteshkew @rishabhrathod01 @shadabbuchh @rohan-arthur