Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Add Java thread information in the Plugin Module #35568

Closed
NilanshBansal opened this issue Aug 9, 2024 · 2 comments · Fixed by #36077
Closed

[Task]: Add Java thread information in the Plugin Module #35568

NilanshBansal opened this issue Aug 9, 2024 · 2 comments · Fixed by #36077
Assignees
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Stability Issue Every issue handle by Stability Pod Stability Pod For all issues/tasks to be prioritized under Stability pod Task A simple Todo

Comments

@NilanshBansal
Copy link
Contributor

NilanshBansal commented Aug 9, 2024

This is required to rule out the possibility of blocking IO operations on main thread.
From the #monitoring channel, we found out that the /actions/execute API calls have the highest frequency of getting invoked and the presence of any blocking IO in this call affects our entire system adversely.

This task aims to add logs in the plugin module for Java threads from the execute() function call.
Ref: https://theappsmith.slack.com/archives/C01EDBBC4JW/p1723118766951209?thread_ts=1723116189.088799&cid=C01EDBBC4JW

Why?

Help in minimizing production downtimes.

@NilanshBansal NilanshBansal added Task A simple Todo Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Stability Issue Every issue handle by Stability Pod labels Aug 9, 2024
@github-actions github-actions bot added Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Stability Pod For all issues/tasks to be prioritized under Stability pod labels Aug 9, 2024
@NilanshBansal NilanshBansal self-assigned this Aug 28, 2024
@NilanshBansal
Copy link
Contributor Author

Tried updating the lombok package version, reconfiguring the pom.xml files but it does not help. For some reason, the logger does not work within the /appsmith-plugins directory.
If this does not work the alternative approach would be to add System.out.println()
cc: @nidhi-nair @manish535 if you have any ideas on what could be the reason for this please guide.

@NilanshBansal
Copy link
Contributor Author

Created another issue here for fixing the logging in plugins directory as it needs more research.
Working on the current task with another approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Stability Issue Every issue handle by Stability Pod Stability Pod For all issues/tasks to be prioritized under Stability pod Task A simple Todo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant