-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New initializer injection TyphoonParameterInjectedByFactoryReference #153
Comments
Any comments @alexgarbarev ? |
No, it's clear. And I think we have to do same API with boxing primitives for initializer. But now I see that it cannot be done by KVC, and I have to implement same way as KVC (with unboxing) but for initializer invocation. FactoryReference way also should be introduced in xml, I believe. Also I want to add void* pointer injection. It will be useful to inject dispatch_queue_t for example. We have to parse ^void type at runtime and add to typeDescription |
👍 It would be great to give initializer the same treatment. Take a look at TyphoonTypeDescriptor, I believe it can decode void* arguments . . . (though it hasn't been used directly for this purpose yet). For void*, both these conditions must be true
A point that is not directly related, but interesting: As you've probably observed, the objective-C runtime gives very good introspection for properties. . . But for selector arguments its not quite as good, its either the primitive type or simply 'id'. . . this is why Typhoon's auto-wiring macros and by-type injection is only available for properties. . . for initializer it has to be manually specified. . . Primitive introspection is there though. . . |
Relates to: #141 |
If anyone wants to take this issue, just assign it to yourself. Otherwise I'll take it in the next few days. |
This issue waits until #162 resolved (because depends on) |
Issue #162 is implemented and can be closed after review. |
This issue can be closed after review |
. . to match the recent addition to property-style injectors.
The text was updated successfully, but these errors were encountered: