Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method Injection support? #198

Closed
alexgarbarev opened this issue Mar 18, 2014 · 3 comments
Closed

Method Injection support? #198

alexgarbarev opened this issue Mar 18, 2014 · 3 comments
Labels
ready-for-review

Comments

@alexgarbarev
Copy link
Contributor

I think about supporting something like

[definition injectMethod:@selector(setX:Y:Z:) withParameters:^(TyphoonMethod *method){
    [method injectParameterWith:[self Xdefinition]];
    [method injectParameterWith:[self Ydefinition]];
    [method injectParameterWith:[self Zdefinition]];
}];

where TyphoonMethod is renamed TyphoonInitializer object
@jasperblues
Copy link
Member

This looks useful. Of course, it will have to be explicit injections because the deep type introspection is only available for properties.

@jasperblues
Copy link
Member

Relates to #86

alexgarbarev added a commit that referenced this issue Mar 19, 2014
@alexgarbarev
- Rename TyphoonInitializer -> TyphoonMethod
7148e39 
- Refactor TyphoonMethod to be common (removed dependency on definition)
- Refactor injections to use new method for method injections
- Fixed bug in TypeDescriptor when it was primitive for unknown '@' object
Related to #198
@alexgarbarev
Copy link
Contributor Author

Done. Ready to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasperblues @alexgarbarev