Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support object-graph scope for definitions with runtime args #202

Closed
alexgarbarev opened this issue Mar 23, 2014 · 3 comments
Closed

Support object-graph scope for definitions with runtime args #202

alexgarbarev opened this issue Mar 23, 2014 · 3 comments
Assignees
@alexgarbarev
Labels
ready-for-review

Comments

@alexgarbarev
Copy link
Contributor

Definitions with runtime args should works with object-graph scope. Add shared object search by key + args, instead of only by key.
@alexgarbarev alexgarbarev self-assigned this Mar 23, 2014
@alexgarbarev
Copy link
Contributor Author

Also I found that circular dependency didn't work for all property injection except Reference and ByType injection. (FactoryReference, Collections, etc..)
Will rework circular dependency code for property injections

@jasperblues
Copy link
Member

Do you want someone to show you around the existing code for circular dependencies?

@alexgarbarev
Copy link
Contributor Author

No, thanks. I already know how to fix it with right way.

alexgarbarev added a commit that referenced this issue Mar 24, 2014
@alexgarbarev
#202 Definitions with runtime args supports object-graph scope. Bugs …
bfa43b8 
…related to circular dependency are fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgarbarev alexgarbarev

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasperblues @alexgarbarev