Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename injectProperties: #205

Closed
alexgarbarev opened this issue Mar 29, 2014 · 5 comments
Closed

rename injectProperties: #205

alexgarbarev opened this issue Mar 29, 2014 · 5 comments

Comments

@alexgarbarev
Copy link
Contributor

Since we support method injections now, njectProperties: method now named incorrect.
Which method name should be?

  • doInjectionsOn:
  • injectOn:
  • something else?
@jasperblues
Copy link
Member

I like simply 'inject'

@jasperblues
Copy link
Member

This is really 'ready for review' ?

@fortinmike
Copy link

The documentation for this feature seems to be outdated. It still talks about -injectProperties: and not the new -inject: and -inject:withDefinition: methods.

@jasperblues
Copy link
Member

@fortinmike Oops. fixed. How does it look now?

@fortinmike
Copy link

@jasperblues Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants