Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge TyphoonInitialAssemblies and TyphoonInitialAssemblies(iPhone/iPad) if both are present in plist #262

Closed
gumanoid opened this issue Oct 10, 2014 · 1 comment

Comments

@gumanoid
Copy link

Consider this config:

TyphoonInitialAssemblies

  • DeviceIndependentComponents

TyphoonInitialAssemblies(iPhone)

  • IPhoneSpecificComponents

TyphoonInitialAssemblies(iPad)

  • IPadSpecificComponents

What I would expect is that Typhoon will merge iPhone/iPad-specific assembly list with general one. But Typhoon just ignores TyphoonInitialAssemblies config key and uses one of device-specific lists.

If there is any reason against merging, the documentation should be more explicit about that.

@alexgarbarev
Copy link
Contributor

Hi @gumanoid! Thanks for feedback.

Correct, devices-specific assemblies has higher priority.
If you need something like "merge", you can just inherit your IPhoneSpecificComponents and IPadSpecificComponents classes from DeviceIndependentComponents.

In that case each device specific assembly will have all components from the device independent assembly

I think that approach is more clear than implicit merging

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants