Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering assemblies is longer since 2.3.x #278

Closed
qLag opened this issue Nov 14, 2014 · 4 comments
Closed

Registering assemblies is longer since 2.3.x #278

qLag opened this issue Nov 14, 2014 · 4 comments

Comments

@qLag
Copy link

qLag commented Nov 14, 2014

In my application I have 3 assemblies i want to register TyphoonDefinition(s) with the
+(void)factoryWithAssemblies:(NSArray *)assemblies
method of TyphoonBlockComponentFactory class.

In version 2.3.X of Typhoon this method takes about 25% more time than the same method in version 2.1.5 .

Is this normal (I need to speed up my app launching and Typhoon doesn't help me at this point).

@alexgarbarev
Copy link
Contributor

Yes, I think it's because new autoInjection feature (It hasn't documentation yet).
Currently we haven't API to disable it.
Try to comment out this line:

[self attachPostProcessor:[TyphoonFactoryAutoInjectionPostProcessor new]];

in this TyphoonComponentFactory.m file.
If that helps, I'll push API to disable that soon.

@alexgarbarev
Copy link
Contributor

Pushed the fix.
Try to pull :head version and add following key into your Info.plist file:
TyphoonAutoInjectionEnabled (BOOL) - NO
It will disable autoIinjection feature globaly

@qLag
Copy link
Author

qLag commented Nov 14, 2014

Ok Thx, i will try that :)

@qLag
Copy link
Author

qLag commented Nov 14, 2014

Okay, it works great with this fix :)

@qLag qLag closed this as completed Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants