Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use CFBundleExecutable instead of CFBundleName? #359

Closed
VincentWenShuo opened this issue May 28, 2015 · 7 comments
Closed

Can we use CFBundleExecutable instead of CFBundleName? #359

VincentWenShuo opened this issue May 28, 2015 · 7 comments

Comments

@VincentWenShuo
Copy link

We encounter a problem with changing app name when we are using Typhoon framework.

The problem is in TyphoonIntrospectionUtils.m, for function "Class TyphoonClassFromString(NSString *className)"

NSString *defaultModuleName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleName"];

So if we change the BundleName in Info.plist to a different name from the project name, the Typhoon won't work any more.

Can we use CFBundleExecutable or something else instead? So that we can easily change our app name.

Thanks a lot.

@jasperblues
Copy link
Member

That was for swift name-spacing. Does it work with CFBundleExecutable?

@VincentWenShuo
Copy link
Author

Yes, we tried and it worked. But we are using pod for our CI, so it is
better you guys can modify this.

Thanks

On Thursday, May 28, 2015, Jasper Blues notifications@github.com wrote:

That was for swift name-spacing. Does it work with CFBundleExecutable?


Reply to this email directly or view it on GitHub
#359 (comment)
.

@jasperblues
Copy link
Member

Ok. Please paste the update method from TyphoonIntrospectionUtils here.

@VincentWenShuo
Copy link
Author

Just change

NSString *defaultModuleName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleName"];

to

NSString *defaultModuleName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleExecutable"];

@jasperblues
Copy link
Member

Done. You can now try this with:

pod 'Typhoon', :head

@VincentWenShuo
Copy link
Author

It is working now. thanks.

@jasperblues
Copy link
Member

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants