Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<TyphoonInjectionAware> -setAssembly: should be renamed to setFactory: #84

Closed
rhgills opened this issue Sep 19, 2013 · 6 comments
Closed

<TyphoonInjectionAware> -setAssembly: should be renamed to setFactory: #84

rhgills opened this issue Sep 19, 2013 · 6 comments

Comments

@rhgills
Copy link
Contributor

rhgills commented Sep 19, 2013

No description provided.

@rhgills
Copy link
Contributor Author

rhgills commented Sep 19, 2013

It actually accepts an object of type TyphoonComponentFactory

@jasperblues
Copy link
Member

Oops. Yes let's fix that. . . as its a new feature, we can go ahead without deprecating.

@rhgills
Copy link
Contributor Author

rhgills commented Oct 3, 2013

Apologies for the prolonged absence. Still okay to go ahead without deprecating?

@rhgills
Copy link
Contributor Author

rhgills commented Oct 30, 2013

Assuming it is, fixed in fcae76d.

@rhgills rhgills closed this as completed Oct 30, 2013
@jasperblues
Copy link
Member

Yes, its ok :)

@rhgills
Copy link
Contributor Author

rhgills commented Oct 31, 2013

Fantastic. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasperblues @rhgills