Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminated requirement to use -all_load linker flag. #109

Merged
merged 1 commit into from
Nov 28, 2013
Merged

Eliminated requirement to use -all_load linker flag. #109

merged 1 commit into from
Nov 28, 2013

Conversation

RCacheaux
Copy link
Contributor

Hi guys,

Thanks so much for this awesome library, our team really enjoys using it.

When we updated our pod dependency from 1.5.3 to 1.5.5, our build broke during linking. I've been able to pinpoint the issue to the -all_load linker flag. There is a known bug with the linker when bringing in categories: http://developer.apple.com/library/mac/#qa/qa2006/qa1490.html

I also found a blog post with more descriptions on the issue:
http://webcache.googleusercontent.com/search?q=cache:FQvKOYmv6mAJ:blog.binaryfinery.com/universal-static-library-problem-in-iphone-sd+&cd=1&hl=en&ct=clnk&gl=us

The blog references a fix RestKit used:
RestKit/RestKit@b96940c

This pull request adds a new macro for embedding a dummy class in all the category implementation files so that the linker can function without the -all_load flag. I built and ran tests for both Mac and iOS.

Looking forward to your feedback!

Cheers,
Rene

jasperblues added a commit that referenced this pull request Nov 28, 2013
Eliminated requirement to use -all_load linker flag.
@jasperblues jasperblues merged commit 53d4311 into appsquickly:master Nov 28, 2013
@jasperblues
Copy link
Member

@RCacheaux - Thanks for the encouragement! We're really enjoying building Typhoon and are glad that so many other folks are finding it useful.

I noticed the same problem that you observed the other day - when I was (belatedly) updating the sample app for iOS7, and updated the Podspec to include "all_load" flag.

. . however, I didn't verify that this actually fixed the problem. . In any case, I'll go ahead and merge your fix - nice trick, btw.

Thanks!

Jasper

@RCacheaux
Copy link
Contributor Author

@jasperblues Thanks so much!

@jasperblues
Copy link
Member

Added the 1.5.7 tag, and pushed to main Spec repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants