Treat type converters as infrastructure components, fixes #21 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work Erik! Would you like to do a quick edit of the docs? Currently type converters are described under 'configuration management & testing' . . . (i need to think about how to organize the docs better.. . . though there's talk of a Typhoon book too ). |
|
Done! |
|
Legend! Thanks Erik! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisited my proposed solution on #21 again and came to the conclusion that it makes more sense to treat the TypeConverters as infrastructure components. Since they should not be considered part of the normal assembly components I think it's better to register them directly with the TypeConverterRegistry when processing the definition.