Property injection mechanism moved to KVC #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work @alexgarbarev !!! Rather than deprecate those primitive injectors, I just went ahead and removed them. I think there's move value in having a cleaner API, and its an easy migration. . . there's one tricky one left: injecting a property with a selector, but it can still be done using valueAsText . Speaking of: valueAsText injection : besides XML, its still sometimes useful to have for:
. . so we'll definitely keep that one around for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now for primitive types (and some structs like CGRect, CGPoint, etc) we can just use TyphoonPropertyInjectedAsObjectInstance with NSNumber or NSValue as object.
Keep TyphoonPropertyInjectedWithStringRepresentation in place to support xml as is. I thought about removing this injection, but in our xml format we dont know types, so they obtained at runtime.