Fix bug in injectProperties when dealing with subclassing #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperblues
added a commit
that referenced
this pull request
May 9, 2013
Fix bug in injectProperties when dealing with subclassing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15 has a bug where Knight would try to be injected with definitions from CavelryMan and CavelryMan would not be injected with definitions from Knight.
I've fixed this and added a unit test.
However it does raise the question what should be injected when there is a definition of quest that is different for CavelryMan and Knight? I would expect CavelryMan definition to override the Knight definition however currently it is last definition wins.
How does Typhoon handle this normally?