Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added instantiateInitialViewController to TyphoonStoryboard #192

Merged
merged 3 commits into from
Mar 10, 2014
Merged

Added instantiateInitialViewController to TyphoonStoryboard #192

merged 3 commits into from
Mar 10, 2014

Conversation

bmorganpa
Copy link
Contributor

Also fixed a warning on storyboardWithName:bundle:

@jasperblues
Copy link
Member

Thanks @bmorganpa !! Much appreciated.

@alexgarbarev can you please review/merge this, as you're currently working in this area.

alexgarbarev added a commit that referenced this pull request Mar 10, 2014
@alexgarbarev
Merge pull request #192 from bmorganpa/bam_storyboard
8c187b5 
Added instantiateInitialViewController to TyphoonStoryboard
@alexgarbarev alexgarbarev merged commit 8c187b5 into appsquickly:master Mar 10, 2014
alexgarbarev added a commit that referenced this pull request Mar 10, 2014
@alexgarbarev
Removed 'instantiateInitialViewController' overrides since it is not …
b6f7d64 
…needed (and does injection twice) #192
@alexgarbarev
Copy link
Contributor

Thanks @bmorganpa for tests.
No need to override instantiateInitialViewController because calling [super instantiateInitialViewController] calls instantiateViewControllerWithIdentifier: internally.
Check that your test passed after removing this override (b6f7d64).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmorganpa @jasperblues @alexgarbarev