Improve circular dependencies resolution. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: More complex setups cause infinite recursion.
jasperblues
added a commit
that referenced
this pull request
Jun 30, 2013
Improve circular dependencies resolution.
|
@drodriguez Thanks for you contribution! Definitely an improvement. Do you have a test case where the more complex set up breaks? I think you're right, it's most likely in the block-swizzling. |
|
Yes, I will clean it and send it. I didn’t want to send something that breaks without the solution. I will try to prepare it tonight. |
That is very kind of you :) . . We will gladly take further contributions. . However, if you're done for now, simply sending the test-case as is, would be most helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: More complex setups cause infinite recursion.
Related to #25.
This is the small fix I talked about, but while it fixes the test and creates a good object graph, when I tried with a little more complex object graph, some other part of Typhoon start breaking down.
I have done a little test, and it also works for singleton scoped objects.