Experimental circular dependency fix #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x' into experimental-circular-dependency-fix
jasperblues
added a commit
that referenced
this pull request
Jul 30, 2013
…ncy-fix Experimental circular dependency fix
|
Great work. |
|
Super contribution. Big thanks Robert. |
|
Thanks, my pleasure! |
|
Looks like I can no longer reproduce the OS X test crasher. Did you do anything to fix it? |
|
No, nothing touched there from me. . . . I did notice circular deps still not 100% OK. Created a circular dependency on iOS, and got the app to crash. |
|
Strange! I can't see anything wrong from looking at the code around where the screenshot shows the crash. Might have been incidentally fixed by switching over to OCLogTemplate. Regarding the circular dependency crash - I haven't noticed anything myself. Looks like we need more test cases there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25.
I took the opportunity to clean up the code as I tried to understand it. In particular, handling assembly method calls and, to a lesser extent, constructing the instances. I think we're starting to see an opportunity for a few new abstractions down the line. For example, there are lots of cohesive methods in TyphoonComponentFactory(InstanceBuilder) that handle property injection.
Passes all iOS tests, but the OS X tests crash in
-[CampaignQuest description]. After I have a chance to look into and fix that, this should be good to go. You'll find a screenshot of the OS X tests crashing below. The stack trace is not stable across runs, so definitely a memory issue.Let me know what you think!