Add newlines to end of file. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to merge this, but what's the justification? Is there a particular IDE that prefers newlines? Or is this for version control? |
|
There are a few good points at http://lostechies.com/chrismissal/2012/03/23/newline-at-end-of-file/ and some more discussion at http://stackoverflow.com/questions/72271/no-newline-at-end-of-file-compiler-warning. Essentially there are some minor upsides (and for some compliers some major upsides) and no downsides I can think of. |
jasperblues
added a commit
that referenced
this pull request
Oct 22, 2013
Add newlines to end of file.
|
Ok done. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.