Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMR on is not working #222

Closed
mkleszcz opened this issue Jun 16, 2023 · 3 comments · Fixed by #434
Closed

HMR on is not working #222

mkleszcz opened this issue Jun 16, 2023 · 3 comments · Fixed by #434
Labels
bug Something isn't working

Comments

@mkleszcz
Copy link
Contributor

Describe the bug
HMR throws an error in console on component update.

To Reproduce
Steps to reproduce the behavior:

  1. Run nx start:app
  2. Open application in browser
  3. Change component code
  4. See error in console

Expected behavior
The component should be update in browser without page refresh.

Additional context
It might be connected with some dependencies changes. On master branch it's working, on radix branch it's broken.
@mkleszcz mkleszcz added the bug Something isn't working label Jun 16, 2023
@mkleszcz
Copy link
Contributor Author

Related to #174

@mkleszcz mkleszcz added this to the 2.0.0 milestone Jun 20, 2023
@mkleszcz
Copy link
Contributor Author

It looks like this is an issue with the Vite:( Will report a bug there

@mkleszcz mkleszcz modified the milestones: 2.0.0, 2.1.0 Jun 27, 2023
@mkleszcz
Copy link
Contributor Author

Created an issue: vitejs/vite#13648

@mkleszcz mkleszcz removed this from the 2.1.0 milestone Aug 10, 2023
@mkleszcz mkleszcz mentioned this issue Nov 24, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: HMR not working for the components outside the webapp directory apptension/saas-boilerplate
1 participant
@mkleszcz