Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate top level Kubelet and Container Runtime configs #51

Open
glrf opened this issue Oct 6, 2022 · 0 comments
Open

Deprecate top level Kubelet and Container Runtime configs #51

glrf opened this issue Oct 6, 2022 · 0 comments
Labels

Comments

@glrf
Copy link
Contributor

glrf commented Oct 6, 2022

Context

In #50 we introduced the option to manage machine config pools. We also added the option to specify KubeletConfig and ContainerRuntimeConfig as part of the machine config pool parameter.

There is always a 1:1 mapping from container runtime and kubelet config to machine config pool.

We should deprecate the top level kubeletConfigs and containerRuntimeConfigs parameters, as specifying them trough the machine config pool is sufficient and more convenient. We also need to document how to move to the new way of configuring things.

Create follow up to have it finally removed.

Alternatives

Keep two ways of defining KubeletConfig and ContainerRuntimeConfig resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant