Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed on nodejs fs.stat dev #1560

Closed
NoahDragon opened this issue May 17, 2017 · 7 comments
Closed

Failed on nodejs fs.stat dev #1560

NoahDragon opened this issue May 17, 2017 · 7 comments

Comments

@NoahDragon
Copy link

Our program failed on the fs.stat testing case:
image

It worked in 2 month ago: https://ci.appveyor.com/project/tommy351/hexo/build/469

But since the time of this submission (https://ci.appveyor.com/project/tommy351/hexo/build/470), this issue persists.

We checked our code, where we did have any change related to this issue. Moreover, the dev field in file status is ID of device containing file (ref), and our program won't modify this field.

Any help would appreciate.

@IlyaFinkelshteyn
Copy link
Contributor

Did you try to rebuild that last successful commit? This can happen that it fail too now, and most probably this is because of some external dependencies. If you compare build logs (for the same job in matrix -- nodejs_version=7) from builds 469 and 470, you can notice that a lot of npm dependencies (and even npm itself) are different.

@NoahDragon
Copy link
Author

@IlyaFinkelshteyn Thanks, I will take a look at them.

@NoahDragon
Copy link
Author

@IlyaFinkelshteyn I have compared those two logs.
image
Only these three packages are changed, and I don't think these could affect the fs.stat() returns.

Based on my understanding, the device ID should only change when the devices are different. The test case we run is to compare the file status between threads. I think the device ID should be still same. Please correct me if I'm wrong.

@NoahDragon
Copy link
Author

The same test case has passed on Travis-CI, but failed on Appveyor. My assumption is some changes on Appveyor cause this issue, maybe multiple threading or container management.

@JLHwung
Copy link

JLHwung commented Aug 25, 2017

This issue can be reproduced in a very simple setup, a living case can be found at https://ci.appveyor.com/project/JLHwung/appveyor-fs-statsync-issue/build/job/s35bs83etb770x34

The testing code is simple and convenient for narrowing down: https://github.com/JLHwung/appveyor-fs-statSync-issue/blob/5153510d1a68bc8682ec8e5c9c9c559fd697d6c3/index.js

@JLHwung
Copy link

JLHwung commented Oct 27, 2017

This issue might not be related to appveyor, see nodejs/node#16496. Suggest closing it.

@FeodorFitsner
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants