Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Appwrite interface, user preferences #1468

Open
2 tasks done
mateo-meillon opened this issue Mar 27, 2023 · 12 comments
Open
2 tasks done

🐛 Bug Report: Appwrite interface, user preferences #1468

mateo-meillon opened this issue Mar 27, 2023 · 12 comments
Labels
bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth

Comments

@mateo-meillon
Copy link

👟 Reproduction steps

When I go to a authed user-> /console//auth/user- and remove an remove an preference, the update button does not become active and I cannot save the changed, but when adding one and deleting another, then saving -> it works. I only tested it by deleting 1/1 preference

👍 Expected behavior

It should delete the preference for the user

👎 Actual Behavior

It did nothing -> proof when reloading

🎲 Appwrite version

Version 1.2.x

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@mateo-meillon mateo-meillon added the bug Something isn't working label Mar 27, 2023
@safwanyp
Copy link
Contributor

Seems like there's a few other bugs with regards to updating user preferences.

  1. If there's more than 1 preference in the console for a user, the all preferences except the first one can be deleted as expected.
  2. If there's exactly 1 preference in the console for a user, that preference cannot be deleted as the Update button stays disabled.
  3. If there's more than 1 preference in the console for a user, clicking the X icon for the first preference gets rid of all the preferences for that user (only in the UI), and the Update button stays disabled in this case as well.

I've tried attaching screen caps to demonstrate this.

P.S. GitHub video previews have always been weird for me. If it seems like nothing is happening in the videos, just scroll back to the start and it'll work.

Case 1

Even though I deleted them from bottom to top in this preview, it doesn't have to be done that way in this case.

case.1.mp4

Case 2

case.2.mp4

Case 3

case.3.mp4

@safwanyp
Copy link
Contributor

safwanyp commented Mar 28, 2023

I'd love to work on this issue and create a PR. Let me know if possible!

It seems like a really simple fix to be honest.

@stnguyen90 stnguyen90 added the product / auth Fixes and upgrades for the Appwrite Auth label Mar 28, 2023
@stnguyen90
Copy link
Contributor

@Maettis thanks for raising this! 🙏🏼

@safwanyp this might have been fixed already, but let me double check with the team.

@stnguyen90 stnguyen90 self-assigned this Mar 28, 2023
@stnguyen90
Copy link
Contributor

@safwanyp looks like it hasn't. Assigned!

@stnguyen90 stnguyen90 assigned safwanyp and unassigned stnguyen90 Mar 28, 2023
@safwanyp
Copy link
Contributor

@stnguyen90 Great, thanks!

@safwanyp
Copy link
Contributor

@stnguyen90 pinging to inform you that i just made the PR.

@joeyouss
Copy link

Thank you, our team will review your PR as soon as possible.

@ItzNotABug
Copy link
Member

Update: There seems to be also the case for whitespaces.
Using " " (spaces) for both key and value allows saving the preferences.

EmptyPreference.mov

@Vedsaga
Copy link

Vedsaga commented Dec 14, 2023

Not sure, why we can not update the preference via console... may be this might be related to this itself?

@wess
Copy link
Contributor

wess commented Dec 29, 2023

PR: #696

@xuelink
Copy link

xuelink commented May 8, 2024

pref-bug.mp4

@Megamannen
Copy link

Megamannen commented Nov 19, 2024

Preferences are typed internally, but using the console to change them converters them all to strings. Type-column in the table is needed, it's not a case of "if the comment get enough votes". This can break stuff!

Dangrous stuff:

  • Booleans that you think you set to false is really set to "false" which is considered true in javascript
  • Numbers that you think you set to 10 is really set to "10" which might crash some calculation

#8989
#8989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants