-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link SCTs to appropriate online source #14
Comments
The trick with this is that I'm not entirely sure what the best place to link to is. crt.sh can be a bit rough at times. |
I'd say https://crt.sh/ is fine. I mean what do you mean by "rough"? Some downtime? IMHO that's okay and not a big argument against linking to crt.sh. If they are down, you can hardly do anything and I would encounter the same if I search there manually. Otherwise let the user adjust this in the settings or provide multiple links. |
After considering this, I think it would be best if it simply linked to the SCTs in question, or at least information about the particular SCTs. |
Hi @april. Another of the Outreachy masses here! May I please give this issue a go? I'm still getting familiar with the code base, so if you have any helpful hints on where to start that would be most welcome. Cheers! |
hey @april . I am an outreachy applicant , haven't made any contributions till now . Can i work on this issue ? . |
Hey @april . I am set up, have gotten familiar with everything and am ready to dive in. But I was wondering what you had in mind? I could easily hard code a link for each CT, similar to ctlognames.js listing each name. Or point to a search URL at crt.sh. But is there a more elegant way to approach this? |
I think simply linking to the policies of the CT operator (cloudflare, google, etc.) is probably the best way to go. In that case, I would hard-code it in a configuration file. ctlognames.js is programatically generated, not hardcoded. :) |
Thanks very much @april! I will work on this :) |
Quick question @april - as it might be a longer issue to source all the sites, is it possible to please be assigned this issue? Thanks again! |
Sure, yes, go ahead. |
@nikk15 are you still working on this? |
@noorfathima11 I started working on something else when I didn't hear back. Thanks for asking. Please go ahead! :) |
Thank you so much. |
Hey @april . I have solved this bug. |
When displaying SCT information it would be nice to have some link e.g. to crt.sh or alike, pointing to the accompanying online entry in CT logs describing this certificate/SCT.
The text was updated successfully, but these errors were encountered: