Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link SCTs to appropriate online source #14

Open
BenBE opened this issue Jul 31, 2018 · 14 comments
Open

Link SCTs to appropriate online source #14

BenBE opened this issue Jul 31, 2018 · 14 comments
Labels
good first issue Good for newcomers / Outreachy participants

Comments

@BenBE
Copy link

BenBE commented Jul 31, 2018

When displaying SCT information it would be nice to have some link e.g. to crt.sh or alike, pointing to the accompanying online entry in CT logs describing this certificate/SCT.

@april
Copy link
Owner

april commented Aug 1, 2018

The trick with this is that I'm not entirely sure what the best place to link to is. crt.sh can be a bit rough at times.

@rugk
Copy link

rugk commented Oct 20, 2018

I'd say https://crt.sh/ is fine. I mean what do you mean by "rough"? Some downtime? IMHO that's okay and not a big argument against linking to crt.sh. If they are down, you can hardly do anything and I would encounter the same if I search there manually.

Otherwise let the user adjust this in the settings or provide multiple links.

@april
Copy link
Owner

april commented Feb 28, 2019

After considering this, I think it would be best if it simply linked to the SCTs in question, or at least information about the particular SCTs.

@april april added the good first issue Good for newcomers / Outreachy participants label Feb 28, 2019
@nikk15
Copy link

nikk15 commented Feb 28, 2019

Hi @april. Another of the Outreachy masses here! May I please give this issue a go? I'm still getting familiar with the code base, so if you have any helpful hints on where to start that would be most welcome. Cheers!

@sudhirsaharan
Copy link

hey @april . I am an outreachy applicant , haven't made any contributions till now . Can i work on this issue ? .

@nikk15
Copy link

nikk15 commented Mar 1, 2019

Hey @april . I am set up, have gotten familiar with everything and am ready to dive in. But I was wondering what you had in mind? I could easily hard code a link for each CT, similar to ctlognames.js listing each name. Or point to a search URL at crt.sh. But is there a more elegant way to approach this?
Thanks in advance for any pointers :)

@april
Copy link
Owner

april commented Mar 5, 2019

I think simply linking to the policies of the CT operator (cloudflare, google, etc.) is probably the best way to go. In that case, I would hard-code it in a configuration file. ctlognames.js is programatically generated, not hardcoded. :)

@nikk15
Copy link

nikk15 commented Mar 5, 2019

Thanks very much @april! I will work on this :)

@nikk15
Copy link

nikk15 commented Mar 5, 2019

Quick question @april - as it might be a longer issue to source all the sites, is it possible to please be assigned this issue? Thanks again!

@april
Copy link
Owner

april commented Mar 13, 2019

Sure, yes, go ahead.

@noorfathima11
Copy link

@nikk15 are you still working on this?

@nikk15
Copy link

nikk15 commented Mar 23, 2019

@noorfathima11 I started working on something else when I didn't hear back. Thanks for asking. Please go ahead! :)

@noorfathima11
Copy link

Thank you so much.

@noorfathima11
Copy link

noorfathima11 commented Apr 1, 2019

Hey @april . I have solved this bug.
image
As you can see in the image there is appropriate link to the corresponding Log Name in Embedded SCTs section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers / Outreachy participants
Projects
None yet
Development

No branches or pull requests

6 participants