aqua update-aqua failed on Windows

[suzuki-shunsuke]

aqua info

$ aqua -v
aqua version 2.10.1 (fbf3b157b21897fa2f315fbc30474acafded108d)

OS (Windows, Linux, macOS, etc): windows
CPU Architecture (amd64, arm64, etc): amd64

Overview

aqua update-aqua failed on Windows.

How to reproduce

Run aqua update-aqua with the latest aqua on Windows.

Debug output

No response

Expected behaviour

aqua skips updating aqua because the current aqua version is same with the new version.

Actual behaviour

aqua tried to update aqua and failed.

https://github.com/aquaproj/aqua/actions/runs/5704029804/job/15457238499

FATA[0000] aqua failed                                   aqua_version=2.10.1 env=windows/amd64 error="download aqua: create a file: open C:\\Users\\runneradmin\\AppData\\Local\\aquaproj-aqua\\bin\\aqua.exe: The process cannot access the file because it is being used by another process." new_version=v2.10.1 program=aqua
Error: Process completed with exit code 1.

Important Factoids

aqua_version is not v2.10.1 but 2.10.1.

Reference

• https://github.com/orgs/aquaproj/discussions/2510

[airtonix]

so my experiences is slightly different.

1. be on v2.21.2
2. run aqua update-aqua
3. result: nothing. no output.
4. run aqua update-aqua v2.17.4
5. result: nothing. no output.
6. run aqua update-aqua 2.17.4
7. result: get github error that it can't find the 2.17.4 tag

error #7 makes sense since the releases are tagged in the format v{version}

related to aquaproj/aqua-installer#578

[suzuki-shunsuke]

https://github.com/orgs/aquaproj/discussions/2510#discussioncomment-7647449

[suzuki-shunsuke]

run aqua update-aqua
result: nothing. no output.

aqua update-aqua doesn't output anything if the new version is already installed.

[suzuki-shunsuke]

There are several solutions.
We'll try them.

https://stackoverflow.com/questions/1211948/best-method-for-implementing-self-updating-software

[airtonix]

@suzuki-shunsuke Are you saying that your vision for aqua update-aqua is that it only ever installs the latest version?

clarifying that this mean it won't ever install versions older than the bootstrap version?

if this is the case, then we shouldn't bother accepting a version parameter and make it clear that the installer only ever installs the latest version possible.

[suzuki-shunsuke]

Are you saying that your vision for aqua update-aqua is that it only ever installs the latest version?

No. aqua update-aqua installs the latest version by default, but you can install old versions.

aqua update-aqua [<version>]

e.g.

aqua update-aqua v2.0.0

[suzuki-shunsuke]

Resolved.

• fix: fix a bug that update-aqua fails on Windows #2871
• https://github.com/aquaproj/aqua/releases/tag/v2.27.4