Add identifiers to the report metadata section #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgreinho
changed the title
This patch adds 2 identifiers to the report metadata section:
- a scan id, which which allows to identify a specific scan run
- a URL to ensure we know where the report was generated from
The main use case behind this patch is to be able to use the reports
without having to add extra context. For now we agreed on a convention
to name the report file as `{owner}-{repo}-{timestamp}.json`, but this
information gets lost when the content of the repost is simply shared
via email or pastebin.
rgreinho
force-pushed
the
metadata/identifiers
branch
from
b17bc5f to
5094e82
Compare
|
Looks like |
|
hi @itaywol can you help with the this? |
|
@naortalmor1 @itaywol it looks like all the tests passed now 👍 Ready to review? |
|
Yep on it |
naortalmor1
approved these changes
Aug 8, 2022
|
Hi @rgreinho thanks for contributing! Merged (: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds 2 identifiers to the report metadata section:
The main use case behind this patch is to be able to use the reports
without having to add extra context. For now we agreed on a convention
to name the report file as
{owner}-{repo}-{timestamp}.json, but thisinformation gets lost when the content of the repost is simply shared
via email or pastebin.