Query re Installing from sources

[davidhay1969]

Hey

Reading Installing from sources, it's not 100% clear what the reader needs to do - I'm probably misunderstanding, but I was of the opinion that go get would "go get" the binary into $GOPATH/bin : -

ls -al $GOPATH/bin/

total 16996
drwxr-x--- 2 root root     4096 Apr  8 09:30 .
drwxr-x--- 5 root root     4096 Apr  8 09:29 ..
-rwxr-x--- 1 root root 17392147 Apr  8 09:57 kube-bench

file $GOPATH/bin/kube-bench 

/home/daveh/go/bin/kube-bench: ELF 64-bit MSB executable, IBM S/390, version 1 (SYSV), dynamically linked, interpreter /lib/ld64.so.1, not stripped

whereas, if we're really building from source, I'm guessing that we want to do something like this: -

mkdir -p $GOPATH/src/github.com/aquasecurity
cd $GOPATH/src/github.com/aquasecurity

git clone https://github.com/aquasecurity/kube-bench.git

cd $GOPATH/src/github.com/aquasecurity/kube-bench
go build -o kube-bench .

which gives us the binary, albeit in the cloned repo: -

file ./kube-bench 

./kube-bench: ELF 64-bit MSB executable, IBM S/390, version 1 (SYSV), dynamically linked, interpreter /lib/ld64.so.1, not stripped

ls -al kube-bench 

-rwxr-x--- 1 root root 17384496 Apr  8 10:01 kube-bench

So, to summarise, are we kinda combining the instructions to GET and BUILD the binary in the same section of the doc ?

Sorry if I'm misunderstanding, Dave

[yoavrotems]

Actually I think you are right and it is mixup, also there are some changes and go modules in 1.16 so maybe we should add coverage for that too

[davidhay1969]

More than happy to help update the doc if that'd help ?

[yoavrotems]

Sure you are very welcome ! There is also a new documentation site https://aquasecurity.github.io/kube-bench/dev

[davidhay1969]

Apologies for the HUGE delay @yoavrotems - have raised a PR #928 as a starting point .... happy to add more, if that'd help ?