Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE 1.6 CIS benchmark for GCP environment #1662

Closed
guyjerby opened this issue Aug 13, 2024 Discussed in #1661 · 6 comments
Closed

GKE 1.6 CIS benchmark for GCP environment #1662

guyjerby opened this issue Aug 13, 2024 Discussed in #1661 · 6 comments
Assignees

Comments

@guyjerby
Copy link

guyjerby commented Aug 13, 2024

CIS benchmark for GKE 1.6 is required:

https://workbench.cisecurity.org/benchmarks/16093

@guyjerby
Copy link
Author

guyjerby commented Aug 13, 2024

@ttousai is creating the benchmark , @jerbia can you make sure that we will be able to assign him to the issue?

@itaysk - we will need to build a release for end of August to include the GKE 1.6 - who can assist with building the new release?

@deboshree-b
Copy link

I added a PR here
#1677
@ttousai @guyjerby

@guyjerby
Copy link
Author

guyjerby commented Sep 14, 2024

Thanks @deboshree-b , can you describe in a summary the changes that you have made?
I see that you mapped the GKE 1.6 version and files and also added new checks - were they missed in the previous PR from @ttousai or you made fixes?

I tested it already and managed to run the gke 1.6 - interesting, maybe it was mapped to a different benchmark by mistake?

@ciphx
Copy link

ciphx commented Sep 15, 2024

Hello @guyjerby, I was upgrading CIS benchmarks for my org, so thought of adding an upstream PR. I didn't know that there were open PRs, so I'll compare and pingback. In the future, I would reply from https://github.com/ciphx, as this profile will be deactivated tomorrow.

@guyjerby
Copy link
Author

Thanks @ciphx - so we are also handling some benchmarks for our customers (Aqua security) , for each benchmark that we should work on - I am creating a github issue, so we can use that for tracking, currently I am testing the PR from @ttousai and adding comments, thanks for your assistance, not sure what are the differences, but it seems that we have 2 PR's for the same use.

@afdesk
Copy link
Collaborator

afdesk commented Oct 11, 2024

closed #1672

@afdesk afdesk closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants