Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Input Changes are not written as comments #70

Open
JakeNeyer opened this issue Jun 30, 2022 · 0 comments
Open

Module Input Changes are not written as comments #70

JakeNeyer opened this issue Jun 30, 2022 · 0 comments

Comments

@JakeNeyer
Copy link

The commenter misses leaving comments on changes from module inputs e.g.

module "s3_bucket" {
  source = "terraform-aws-modules/s3-bucket/aws"

  bucket = "my-bucket
  acl    = "private"

  block_public_acls       = true -> false
}

would not leave a comment. It would receive Public access block does not block public ACLs .... not writing as not part of the current PR

Unlike other outputs, the tfsec JSON output does not support "via". I think once that is added to tfsec, the commenter can additionally parse "via" links to get localized files rather than just module paths which do not show as a PR change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant