You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The commenter tool is really cool how it targets comments in a PR directly to any offending line which will change in that PR, and equally cool is how it doesn't spam a PR with comments relating to lines which aren't changing in a PR. I've googled around a bunch and this tool was the only one I could find which had that capability.
It could be even cooler if that commenter tool supported json from any random code scanner, rather than being hardcoded for tfsec json keys. For example, here's a sample of output from ansible-lint:
Those fields don't exactly map to the fields commenterlooks for, but they're pretty close. It would be cool if I could remap fields when calling the commenter tool to make it work on any json from any code scanner. In the above example, I might call the commenter tool like this:
commenter \
--rule-id 'json:"check_name"' \
--file-name 'json:"location.path"' \
... and so on...
And of course the default behavior could be kept if I didn't explicitly remap any fields, so it's behavior with tfsec json could be unchanged.
The text was updated successfully, but these errors were encountered:
The
commenter
tool is really cool how it targets comments in a PR directly to any offending line which will change in that PR, and equally cool is how it doesn't spam a PR with comments relating to lines which aren't changing in a PR. I've googled around a bunch and this tool was the only one I could find which had that capability.It could be even cooler if that
commenter
tool supported json from any random code scanner, rather than being hardcoded for tfsec json keys. For example, here's a sample of output from ansible-lint:Those fields don't exactly map to the fields
commenter
looks for, but they're pretty close. It would be cool if I could remap fields when calling thecommenter
tool to make it work on any json from any code scanner. In the above example, I might call thecommenter
tool like this:And of course the default behavior could be kept if I didn't explicitly remap any fields, so it's behavior with tfsec json could be unchanged.
The text was updated successfully, but these errors were encountered: