Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply OS-level CVE data to OS-provided go and rust binaries #2012

Closed
kaniini opened this issue Apr 20, 2022 · 1 comment · Fixed by aquasecurity/fanal#481
Closed

apply OS-level CVE data to OS-provided go and rust binaries #2012

kaniini opened this issue Apr 20, 2022 · 1 comment · Fixed by aquasecurity/fanal#481
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kaniini
Copy link

kaniini commented Apr 20, 2022

I am working on using Trivy to scan Alpine-provided Go and Rust packages for vulnerabilities. This has already proven to be very useful, we have already mitigated a few CVEs that we had no visibility into.

However, the security team may choose to issue "true negative" secfixes data for some packages.

The problem is that Trivy does not consider OS-level security fix data when listing vulnerabilities in these binaries themselves. It would be nice to do so if the binary is "owned" by the package manager (/lib/apk/db/installed contains all the registered paths a package should have).

Would it be possible to correlate this data?

@kaniini kaniini added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 20, 2022
@knqyf263
Copy link
Collaborator

We already extract installed files by package managers, then skip scanning those files.
https://github.com/aquasecurity/fanal/blob/63f3f8193fa84a52a7c148aca0d996a1dca8735f/analyzer/pkg/apk/apk.go#L81-L82

If a python package is installed by apk, it should be skipped. But it skips Ruby, Python and Node.js packages for now.
https://github.com/aquasecurity/fanal/blob/63f3f8193fa84a52a7c148aca0d996a1dca8735f/hook/filter/filter.go#L26-L35

I've added Go binaries as well in #481. We don't support Rust binaries currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants