Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): fix infinity loops for pnpm with cyclic imports #6857

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

pnpm allows cyclic imports with peer dependencies.
e.g.:

snapshots:

  browserslist@4.23.0:
    dependencies:
      caniuse-lite: 1.0.30001627
      electron-to-chromium: 1.4.789
      node-releases: 2.0.14
      update-browserslist-db: 1.0.16(browserslist@4.23.0)

  update-browserslist-db@1.0.16(browserslist@4.23.0):
    dependencies:
      browserslist: 4.23.0
      escalade: 3.1.2
      picocolors: 1.0.1

See more in #6848

In these cases you should not end up with an infinite loop.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jun 5, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review June 5, 2024 05:40
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner June 5, 2024 05:40
@knqyf263 knqyf263 added this pull request to the merge queue Jun 5, 2024
Merged via the queue into aquasecurity:main with commit 7d083bc Jun 5, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Jun 5, 2024
@knqyf263
Copy link
Collaborator

knqyf263 commented Jun 6, 2024

@aqua-bot backport release/v0.52

@knqyf263
Copy link
Collaborator

knqyf263 commented Jun 6, 2024

It works in my fork, but it is skipped in Trivy 🤔 I suspect that the merge queue may cause merged_at to be null, but in a personal repository, the merge queue does not seem to be available.
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

@knqyf263
Copy link
Collaborator

knqyf263 commented Jun 7, 2024

@aqua-bot backport release/v0.52

@aqua-bot
Copy link
Contributor

aqua-bot commented Jun 7, 2024

Backport PR created: #6875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(pnpm): infinity loop for markRootPkgs function
3 participants