Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): support the Ext2/Ext3 filesystems #6983

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

aruneko
Copy link
Contributor

@aruneko aruneko commented Jun 21, 2024

Description

Since I have implemented the Ext2/3 filesystems parser on the go-ext4-filesystem that trivy depends, upgraded the library on go.mod file.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@aruneko aruneko requested a review from knqyf263 as a code owner June 21, 2024 04:28
@CLAassistant
Copy link

CLAassistant commented Jun 21, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@knqyf263 knqyf263 marked this pull request as draft June 26, 2024 11:34
@knqyf263
Copy link
Collaborator

Will keep it in draft until it passes the tests.

@aruneko
Copy link
Contributor Author

aruneko commented Jul 1, 2024

I see, I have fixed the failed test.

@knqyf263 knqyf263 marked this pull request as ready for review July 1, 2024 06:12
@knqyf263 knqyf263 requested a review from masahiro331 July 1, 2024 06:12
@knqyf263
Copy link
Collaborator

knqyf263 commented Jul 1, 2024

@masahiro331 Can you please take a look?

@aruneko
Copy link
Contributor Author

aruneko commented Jul 31, 2024

@knqyf263 Could I ask the status of this pull request?

@knqyf263
Copy link
Collaborator

I've been waiting for @masahiro331, but he is not available now. We can merge this PR like #7058 but you need to merge the main branch into this branch to trigger unit tests.

@aruneko aruneko force-pushed the feat/support_ext3 branch from 27c6905 to d171f0d Compare July 31, 2024 09:52
@aruneko
Copy link
Contributor Author

aruneko commented Jul 31, 2024

Thank you for the information. I have rebased my branch onto the latest main branch, and confirmed all tests have passed.

@knqyf263 knqyf263 added this pull request to the merge queue Jul 31, 2024
@knqyf263
Copy link
Collaborator

Thanks for your contribution.

Merged via the queue into aquasecurity:main with commit 35c60f0 Jul 31, 2024
17 checks passed
@aruneko aruneko deleted the feat/support_ext3 branch July 31, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants