Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(debian): use bytes.Index in emptyLineSplit to cut allocation #7065

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Jul 1, 2024

Description

This PR makes use of bytes.Index in emptyLineSplit instead of strings.Index to remove the extra allocation caused by the bytes to string cast.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@paulcacheux paulcacheux changed the title perf(dpkg): use bytes.Index in emptyLineSplit to cut allocation perf(debian): use bytes.Index in emptyLineSplit to cut allocation Jul 1, 2024
@paulcacheux paulcacheux marked this pull request as ready for review July 1, 2024 14:53
@knqyf263 knqyf263 added this pull request to the merge queue Jul 2, 2024
@knqyf263
Copy link
Collaborator

knqyf263 commented Jul 2, 2024

Thanks!

Merged via the queue into aquasecurity:main with commit acbec05 Jul 2, 2024
13 of 18 checks passed
@aqua-bot aqua-bot mentioned this pull request Jul 2, 2024
skahn007gl pushed a commit to skahn007gl/trivy that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants