Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): load only submodule if it is specified in source #7112

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Jul 8, 2024

Description

This PR fixes module loading behaviour. Now if a submodule of a remote module is specified in the source, the module resolver returns the submodule directory, which eliminates evaluation of unnecessary blocks.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review July 8, 2024 10:36
@nikpivkin nikpivkin requested a review from simar7 as a code owner July 8, 2024 10:36
@simar7 simar7 enabled auto-merge August 6, 2024 17:08
@simar7 simar7 closed this Aug 6, 2024
auto-merge was automatically disabled August 6, 2024 17:08

Pull request was closed

@simar7 simar7 reopened this Aug 6, 2024
@simar7 simar7 enabled auto-merge August 6, 2024 17:08
@simar7 simar7 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into aquasecurity:main with commit a4180bd Aug 6, 2024
28 checks passed
@aqua-bot aqua-bot mentioned this pull request Aug 6, 2024
@nikpivkin nikpivkin deleted the tf-subdir branch August 7, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(misconf): Incorrect terraform submodules scanning
2 participants