-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suse): added SUSE Linux Enterprise Micro support #7294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @msmeissn
Thanks for your work!
i left a comments.
also:
- bump
trivy-db
version - update PR title
scope
(feat(suse): ...
) - update
purl
package- perhaps we need to use short name (as for
SLES
) indistro
qualifier - add
micro
inpurlType()
function
- perhaps we need to use short name (as for
(i am on vacation currently, so a bit delayed progress) |
So we are. Take your time. |
396d19f
to
5ae1927
Compare
c4eda8c
to
1ab5a71
Compare
I think I now have it in shape including testcases. |
This adds support for the SUSE Linux Enterprise Micro family. This also fixes also purl logic for SUSE and openSUSE to match standard expectations better. aquasecurity#7221 Signed-off-by: Marcus Meissner <meissner@suse.de>
FWIW for purl i also aligned more with SUSE internal purl guidance, that opensuse distros have "opensuse" as main target, and "suse" for all the SUSE Linux Enterprise ones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me. I left one comment for our convenience.
The tests are failing due to #7538. It's not relevant to this PR.
Signed-off-by: knqyf263 <knqyf263@gmail.com>
This adds support for the SUSE Linux Enterprise Micro family.
#7221
Description
Related issues
Related PRs
Checklist