Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): change a receiver of MarshalJSON #7483

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Sep 10, 2024

Description

A pointer receiver is used for MarshalJSON of some structs by mistake, causing some marshaling problems. If DetectedVulnerability is not a slice, custom MarshalJSON is not called.

PoC

package main

import (
	"encoding/json"
	"fmt"
)

type Status int

func (s *Status) MarshalJSON() ([]byte, error) {
	return json.Marshal("hello")
}

type Foo struct {
	Status Status
}

func main() {
	f1 := []Foo{{Status: 1}}
	jsonData, err := json.Marshal(f1)
	if err != nil {
		panic(err)
	}
	fmt.Println(string(jsonData))

	f2 := Foo{Status: 1}
	jsonData, err = json.Marshal(f2)
	if err != nil {
		panic(err)
	}
	fmt.Println(string(jsonData))
}

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 marked this pull request as ready for review September 10, 2024 19:04
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Sep 11, 2024
Merged via the queue into aquasecurity:main with commit 927c6e0 Sep 11, 2024
13 checks passed
@knqyf263 knqyf263 deleted the fix/marshal_json branch September 11, 2024 05:01
@DmitriyLewen
Copy link
Contributor

@aqua-bot backport release/v0.55

github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@aqua-bot
Copy link
Contributor

Backport PR created: #7490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(template): incorrect JSON marshaling for some fields
3 participants