Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret): change grafana token regex to find them without unquoted #7627

Merged

Conversation

sgaist
Copy link
Contributor

@sgaist sgaist commented Oct 1, 2024

Description

This PR modify the regex so that token with and without quotes/double quotes can be detected.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Sorry, something went wrong.

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sgaist
Thanks for your work!

LGTM
cc. @knqyf263

@knqyf263 knqyf263 added this pull request to the merge queue Oct 2, 2024
Merged via the queue into aquasecurity:main with commit 3e1fa21 Oct 2, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some secret detection regexes expect the value to be surrounded by quotes
3 participants