Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve version comparisons when build identifiers are present #7873

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix: Improve version comparisons when build identifiers are present #7873

merged 2 commits into from
Nov 6, 2024

Conversation

bpfoster
Copy link
Contributor

@bpfoster bpfoster commented Nov 5, 2024

Description

bump go-version to incorporate aquasecurity/go-version#8

Related issues

Related PRs

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@bpfoster bpfoster requested a review from knqyf263 as a code owner November 5, 2024 17:49
knqyf263
knqyf263 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@knqyf263 knqyf263 enabled auto-merge November 5, 2024 19:33
@knqyf263
Copy link
Collaborator

knqyf263 commented Nov 5, 2024

Need to run go mod tidy.

auto-merge was automatically disabled November 5, 2024 21:04

Head branch was pushed to by a user without write access

@bpfoster
Copy link
Contributor Author

bpfoster commented Nov 5, 2024

Thanks, pushed a new commit after go mod tidy.

@knqyf263 knqyf263 enabled auto-merge November 6, 2024 06:13
@knqyf263 knqyf263 added this pull request to the merge queue Nov 6, 2024
Merged via the queue into aquasecurity:main with commit eda4d76 Nov 6, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Nov 6, 2024
Merged
@bpfoster bpfoster deleted the update-go-version-1951e80d branch November 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpfoster @knqyf263