Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alpine): add UID for removed packages #7887

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Nov 7, 2024

Description

Packages found from image config should also contain UID.

These changes also fix a dependency issue for the BOM core (see #7886)
e.g. for CycloneDX:

before:

➜ trivy -q image -f cyclonedx  node:22.11-alpine --removed-pkgs
...
      "ref": "8a1b0f78-6da7-4567-abd3-3d36951588bc",
      "dependsOn": [
        "678d2ae9-d409-4e33-bc1b-7304560ac75a",
        "678d2ae9-d409-4e33-bc1b-7304560ac75a",
        "678d2ae9-d409-4e33-bc1b-7304560ac75a",
...

after:

➜  ./trivy -q image -f cyclonedx  node:22.11-alpine --removed-pkgs

...
      "ref": "b6ada0a0-4305-40bd-a0f4-444bac8ec868",
      "dependsOn": [
        "037012ad-0b78-470d-80d0-efbc1b1a49f7",
        "05852c2e-b9f5-47d2-a54f-23801023974f",
        "076700ec-c73b-48a5-9b03-9ae03a9b2b00",

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Nov 7, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review November 8, 2024 08:53
@knqyf263 knqyf263 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into aquasecurity:main with commit 07915da Nov 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(os): apline removed packages don't have UID
2 participants