Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): do not erase variable type for child modules #7941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(misconf): do not erase variable type for child modules #7941

wants to merge 1 commit into from
+80 −3

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Nov 18, 2024 •
edited
Loading

Description

Example config:

module "aws-rds" {
  source         = "terraform-aws-modules/rds/aws"
  version        = "~> 6.10.0"
  identifier     = "mydb"
  engine         = "postgres"
  family         = "postgres13"
  instance_class = "db.t4g.medium"
}

Before:

trivy conf -d . > log1.txt 2>&1
cat log1.txt |grep "Failed to expand"
2024-11-18T20:36:26+06:00       ERROR   [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.  block="module.aws-rds.module.db_instance.dynamic.restore_to_point_in_time" value="cty.NilVal"
2024-11-18T20:36:26+06:00       ERROR   [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.  block="module.aws-rds.module.db_instance.dynamic.s3_import" value="cty.NilVal"
2024-11-18T20:36:26+06:00       ERROR   [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.  block="module.aws-rds.module.db_instance.dynamic.restore_to_point_in_time" value="cty.NilVal"
2024-11-18T20:36:26+06:00       ERROR   [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.  block="module.aws-rds.module.db_instance.dynamic.s3_import" value="cty.NilVal"
2024-11-18T20:36:26+06:00       ERROR   [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.  block="module.aws-rds.module.db_instance.dynamic.restore_to_point_in_time" value="cty.NilVal"
2024-11-18T20:36:26+06:00       ERROR   [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.  block="module.aws-rds.module.db_instance.dynamic.s3_import" value="cty.NilVal"
2024-11-18T20:36:26+06:00       ERROR   [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.  block="module.aws-rds.module.db_instance.dynamic.restore_to_point_in_time" value="cty.NilVal"
2024-11-18T20:36:26+06:00       ERROR   [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.  block="module.aws-rds.module.db_instance.dynamic.s3_import" value="cty.NilVal"

After:

cat log2.txt |grep "Failed to expand"

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin
fix(misconf): do not erase variable type for child modules
259cbba 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review November 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 Awaiting requested review from simar7 simar7 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(misconf): do not erase variable type for child modules
1 participant
@nikpivkin