Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incrontab(1) mangles comments in incrontab(5) #4

Open
ar- opened this issue Jan 25, 2015 · 7 comments
Open

incrontab(1) mangles comments in incrontab(5) #4

ar- opened this issue Jan 25, 2015 · 7 comments
Assignees

Comments

@ar-
Copy link
Owner

ar- commented Jan 25, 2015

Originals:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=563700
http://bts.aiken.cz/view.php?id=449

incrontab(1) mangles comments in incrontab(5): it changes the first
word on every comment line to "0". For example, if I run incrontab
and create a file with the following comment lines:

Only put 1 space between fields 2 and 3! Additional whitespace will be

assumed to be part of field 3, causing the command to fail!

then incrontab -l shows that I have the following incrontab file:
#0 put 1 space between fields 2 and 3! Additional whitespace will be
#0 to be part of field 3, causing the command to fail!

@ar- ar- added the bug label Jan 25, 2015
@ar- ar- self-assigned this Jan 25, 2015
@ar- ar- added this to the 0.5.11 milestone Jan 25, 2015
@ar-
Copy link
Owner Author

ar- commented Jan 25, 2015

still persistent in v 0.5.10

@ar-
Copy link
Owner Author

ar- commented Jan 25, 2015

after some time of checking I relised that this is not a bug. The man page mentioning comment lines is incron.conf.5 . incrontab is not supposed to have comments. Documentation and implementation are correct. Adding a # to a incrontab file, will cause unexpected behaviour since it is not a valid file, signal or command.

On the other side it would be a useful feature to have command lines in incrontab files, so this issue remains open, but with lower priority.

@ar- ar- added enhancement and removed bug labels Jan 25, 2015
@ar- ar- removed this from the 0.5.11 milestone Jan 25, 2015
@fhanzlik
Copy link

The ability to have comments in the incrontab file, I consider it very useful.

@mustaqimM
Copy link

@ar- Is this not yet fixed? I'm still getting a massive memory leak (~3GB) when I add comments to incrontab

@fhanzlik
Copy link

Ouch! after upgrading to incron 0.5.12, then comment (line starting with '#') in incrontab leads to filling my logs with huge (~35000 lines/sec - but probably more - other lines are discarded by rsyslog) amount messages as:

Jun 24 19:54:12 klempak incrond[1182]: cannot create watch for system table export.conf: (22) Invalid argument

Please, please - allow comment lines in incron tables!

@robert-scheck
Copy link

I'm seeing this here as well, after 3+ hours run time a lot of memory has been wasted by incrond:

root      3903  4.0 33.4 10993028 10966764 ?   Ss   08:04   8:34 /usr/sbin/incrond

@dharmann
Copy link

There are any news for using of comments in incrontab? I'm one of who think that's a good feature, to track some information about the recorderd operation...like in classic cron or sytemd orany other CLI tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants