Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native ether support in Vault and remove all references to EtherToken #125

Closed
izqui opened this issue Mar 13, 2018 · 5 comments
Closed

Comments

@izqui
Copy link
Contributor

izqui commented Mar 13, 2018

Original conversation: aragon/aragonOS#245

@sohkai
Copy link
Contributor

sohkai commented Mar 13, 2018

Dean's https://github.com/decanus/dynamic-vault is a complete upgrade over our existing system; I love it. It's exactly what I was looking for in terms of extensibility / feature detection in the "payment router" but much more elegant.

Totally @izqui's idea, but in writing: we could set this up similar to the run scripts app and have the vault delegate into the "connector" contracts for functionality.

@izqui
Copy link
Contributor Author

izqui commented Mar 13, 2018

I will be working on this today and try to squeeze it into the release :)

@bingen
Copy link
Contributor

bingen commented Mar 13, 2018

Ya, that dynamic vault is really nice!!

@gasolin
Copy link

gasolin commented Mar 14, 2018

Wow! dynamic vault looks cool and definitely like to have it 👍
Though just in case I saw the rest of works for 0.5 milestone are around test and increasing the test coverage. Introducing a new contract feature (which may need extra audit) at last time (I saw in aragon.chat the release might happen in this week?) increase the risk to deliver the short-term goal. And I think dynamic vault deserves a well-thought UI companion to handle new token types like NFT #44.

@izqui
Copy link
Contributor Author

izqui commented Mar 14, 2018

The release is testnet only, and this changes are going to make it into the release without problem. Auditors are going to be reviewing this leading to mainnet launch.

Actually interesting thought about NFTs, it is maybe not a crazy thought that we can do a NFT connector rather than another Vault. We won't be working on this right away but interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants