Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to compare size of compiled byte code between changesets #370

Closed
sohkai opened this issue Jul 24, 2018 · 2 comments · Fixed by #547
Closed

Add tests to compare size of compiled byte code between changesets #370

sohkai opened this issue Jul 24, 2018 · 2 comments · Fixed by #547

Comments

@sohkai
Copy link
Contributor

sohkai commented Jul 24, 2018

Not quite sure how we'd get the old compiled byte code to diff against the new one... but should be possible.

Could be done via a custom Github app, Danger (e.g. see how react's dangerfile does the git actions, or as part of a travis build.

@izqui
Copy link
Contributor

izqui commented Jul 24, 2018

I think something like Danger could be a great tool for this. I believe they even have integration with the new Github Checks API

@sohkai
Copy link
Contributor Author

sohkai commented Aug 30, 2018

Partly done through #387.

Now we just have to figure out how to automate this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants